don't try to copy packages in prod channel

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 52 forks source link

don't try to copy packages in prod channel #124

Closed isuruf closed 3 years ago

isuruf commented 3 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 3 years ago

When there are arch and noarch outputs in the same recipe, noarch output might be uploaded by a different CI, and trying to upload the noarch output to cf-staging. This PR fixes this issue as well.

beckermr commented 3 years ago

Yup that's right! Thanks for fixing!

beckermr commented 3 years ago

There is still a race condition when none of the outputs have made it yet.

isuruf commented 3 years ago

True, but we've ignored that from the beginning right?

beckermr commented 3 years ago

Yup! Just leaving notes for myself on where the problems remain for future me who forgets this entire convo.

isuruf commented 3 years ago

Thanks for the review