conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 52 forks source link

Add CONDA_OVERRIDE_CUDA for current CUDA version. #144

Closed bdice closed 3 years ago

bdice commented 3 years ago

Checklist

This PR adds CONDA_OVERRIDE_CUDA as discussed on Gitter. This will enable packages to specify __cuda versions as a run dependency.

I was able to test that the shyaml logic detects the correct values for CONDA_OVERRIDE_CUDA. See also: conda docs on detected package overrides).

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bdice commented 3 years ago

@conda-forge-admin, please rerender

jakirkham commented 3 years ago

cc @kkraus14 (for vis)

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

bdice commented 3 years ago

@beckermr @jaimergp @isuruf I think this is ready for review. I would like input on how to test this, especially on Windows. The changes for Windows should be scrutinized carefully, don't trust my batch scripting to be correct just because CI passes. 😅

bdice commented 3 years ago

Thanks @isuruf @jaimergp @kkraus14 for the help and code review, it is appreciated. I have resolved all remaining comments and CI is passing now, please review/finalize/merge at your convenience. 👍

jaimergp commented 3 years ago

LGTM!

kkraus14 commented 3 years ago

lgtm 😄