Closed bdice closed 3 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
cc @kkraus14 (for vis)
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.
@beckermr @jaimergp @isuruf I think this is ready for review. I would like input on how to test this, especially on Windows. The changes for Windows should be scrutinized carefully, don't trust my batch scripting to be correct just because CI passes. 😅
Thanks @isuruf @jaimergp @kkraus14 for the help and code review, it is appreciated. I have resolved all remaining comments and CI is passing now, please review/finalize/merge at your convenience. 👍
LGTM!
lgtm 😄
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)This PR adds
CONDA_OVERRIDE_CUDA
as discussed on Gitter. This will enable packages to specify__cuda
versions as a run dependency.I was able to test that the
shyaml
logic detects the correct values forCONDA_OVERRIDE_CUDA
. See also: conda docs on detected package overrides).