Remove msmpi in System32 as well

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 52 forks source link

Remove msmpi in System32 as well #153

Closed isuruf closed 3 years ago

isuruf commented 3 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

cc @leofang

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 3 years ago

That's not an issue with running software. Only the DLLs in C:\Windows\System32 are problematic. There's 100s of different software in azure that we can't possibly delete.

leofang commented 3 years ago

The uninstaller would also clean up the registry, among other actions, to force MS-MPI to look for the correct place at runtime.

isuruf commented 3 years ago

You mean finding smpd.exe? Looking at source code, it finds smpd.exe in the same directory as msmpi.dll first, which is the case for now. Also https://github.com/conda-forge/msmpi-feedstock/blob/master/recipe/activate.bat#L30 needs to be fixed because LIBRARY_BIN is not set outside of conda-build.

leofang commented 3 years ago

Not just smpd. One of the registry keys (MSPMSProvider) points to the dll, and the key is used at initializing the communication service if you are interested in the source. Also, the presence of the registry keys would prevent the installer from doing the right job (installing to a custom path). I'd rather keep things simple by just removing everything, which is really only one more line to add.

isuruf commented 3 years ago

I'd like to keep the maintenance burden lower. After merging this PR, if you run into an issue, we can re-evaluate.

isuruf commented 3 years ago

Can you open an issue in this feedstock to track this?