conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 52 forks source link

Windows: add cuda 11.3 / 11.4 / 11.5 #154

Closed jaimergp closed 2 years ago

jaimergp commented 3 years ago

Checklist

See https://github.com/conda-forge/cudatoolkit-feedstock/issues/58 for more info

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jaimergp commented 3 years ago

@conda-forge-admin, please rerender

jakirkham commented 3 years ago

There are some conflicts. Could you please resolve those Jaime?

jakirkham commented 2 years ago

Am thinking we won't need these with CUDA Enhanced Compatibility ( https://github.com/conda-forge/nvcc-feedstock/pull/71 ), but please let me know if I'm missing something, Jaime 🙂

Looks like we already have CUDA 11.2 here as well, which is the only other thing I think we need

kkraus14 commented 2 years ago

Am thinking we won't need these with CUDA Enhanced Compatibility ( conda-forge/nvcc-feedstock#71 ), but please let me know if I'm missing something, Jaime 🙂

Looks like we already have CUDA 11.2 here as well, which is the only other thing I think we need

I think just because we're enabling CUDA enhanced compatibility doesn't mean that package(s) couldn't opt into using CUDA 11.3 / 11.4 directly if they need newer features.

jaimergp commented 2 years ago

For CEC I think we are fine with 11.2, but I guess it doesn't hurt to have .3 and .4 available in case somebody requests it (even for debugging runs) through the CBC.

leofang commented 2 years ago

This PR blocks https://github.com/conda-forge/nvcc-feedstock/pull/74.

jaimergp commented 2 years ago

I'll add 11.5 while we are at it.

kkraus14 commented 2 years ago

LGTM, thanks @jaimergp

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!