conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 52 forks source link

use URL instead of git to check feedstock-outputs #167

Closed isuruf closed 2 years ago

isuruf commented 2 years ago

This should hopefully fix travis-ci errors

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 2 years ago

@conda-forge/core, this should hopefully fix the travis errors. Would appreciate a quick review to get travis-ci running.

isuruf commented 2 years ago

The raw url contents can be behind in time compared to the actual git repo.

Didn't know that. Thanks for the info

OTOH, we do the final check in the heroku server anyways.

Agreed. This is just a check for the user and is a convenience function, so not a huge deal if it's behind in time slightly.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 2 years ago

Thank you Isuru! 😄 Also thank you Matt for the review 🙂