conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 52 forks source link

Always modify condarc of the env during builds #171

Closed 183amir closed 2 years ago

183amir commented 2 years ago

because ~/.condarc might not be writeable. see: https://github.com/conda-forge/conda-smithy/issues/1518

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

183amir commented 2 years ago

I think I modified too much.

beckermr commented 2 years ago

@isuruf care to take a look?

I don't feel comfortable reviewing this one. This change is pretty finicky and I don't follow all of the envs and how conda treats them.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

183amir commented 2 years ago

@conda-forge-admin, please rerender

isuruf commented 2 years ago

Yeah, I need to check if conda-build respects the condarc in the base environment

183amir commented 2 years ago

It does, we do this already in Bob's CI, https://gitlab.idiap.ch/bob/bob.devtools/-/jobs/247782#L295

INFO@2021-10-21 18:50:45,121: (create) /scratch/builds/bob/bob.devtools/miniconda/condarc
INFO@2021-10-21 18:50:45,121: Enabling reverse caching proxy for conda channels...
INFO@2021-10-21 18:50:45,121: (system) /scratch/builds/bob/bob.devtools/miniconda/bin/mamba info
     active environment : /opt/conda
    active env location : /opt/conda
            shell level : 1
       user config file : /home/conda/.condarc
 populated config files : /scratch/builds/bob/bob.devtools/miniconda/.condarc
                          /scratch/builds/bob/bob.devtools/miniconda/condarc
                          /home/conda/.condarc
          conda version : 4.10.3
    conda-build version : not installed
         python version : 3.9.7.final.0
       virtual packages : __linux=4.19.0=0
                          __glibc=2.17=0
                          __unix=0=0
                          __archspec=1=x86_64
       base environment : /scratch/builds/bob/bob.devtools/miniconda  (writable)
      conda av data dir : /scratch/builds/bob/bob.devtools/miniconda/etc/conda
  conda av metadata url : None
           channel URLs : http://bobconda.lab.idiap.ch:9000/conda-forge/linux-64
                          http://bobconda.lab.idiap.ch:9000/conda-forge/noarch
                          http://bobconda.lab.idiap.ch:8000/pkgs/main/linux-64
                          http://bobconda.lab.idiap.ch:8000/pkgs/main/noarch
          package cache : /scratch/builds/bob/bob.devtools/miniconda/pkgs
                          /home/conda/.conda/pkgs
       envs directories : /scratch/builds/bob/bob.devtools/miniconda/envs
                          /home/conda/.conda/envs
               platform : linux-64
             user-agent : conda/4.10.3 requests/2.26.0 CPython/3.9.7 Linux/4.19.0-17-amd64 centos/7.9.2009 glibc/2.17
                UID:GID : 9001:9001
             netrc file : None
           offline mode : False
183amir commented 2 years ago

@isuruf did you have time to test this?

183amir commented 2 years ago

ping @isuruf

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!