unset CPU_COUNT for github actions as well

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 51 forks source link

unset CPU_COUNT for github actions as well #183

Closed isuruf closed 2 years ago

isuruf commented 2 years ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

cc @wolfv

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

wolfv commented 2 years ago

cool! I wonder if we really need to set it. I haven't had issues with this on Azure in the robostack builds etc.

isuruf commented 2 years ago

Not sure about azure, but was definitely needed for other CI like appveyor, circle ci, travis ci.

isuruf commented 2 years ago

@conda-forge-admin, rerender

jakirkham commented 2 years ago

Seems safer to just set it. Configurations can always change behind the scenes and time spent debugging those kinds of issues is better spent elsewhere

isuruf commented 2 years ago

@jakirkham, yes, we can keep the CPU_COUNT setting for other CI.

@conda-forge/core, any other comments?

wolfv commented 2 years ago

looks good to me!

mariusvniekerk commented 2 years ago

LGTM