fix macos sdk --- UNTESTED

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 51 forks source link

fix macos sdk --- UNTESTED #201

Closed ngam closed 2 years ago

ngam commented 2 years ago

fixes #200

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ngam commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-ci-setup-feedstock/actions/runs/2402456465.

hmaarrfk commented 2 years ago

Are you able to upload this to your channel and then depend on your channel in addition to conda forges for some builds?

ngam commented 2 years ago

Are you able to upload this to your channel and then depend on your channel in addition to conda forges for some builds?

I should first test it like this, right? I will try to do that

ngam commented 2 years ago

It will be good to hear from people about this in general. The vmImages from Azure do provide a selection of SDKs, and they're (I think) are organized based on support. So macos-11 will get you a number of them (quite a few), and macos-12 will get you the three missing ones here, 12.* (macos-11 does have 12.0 and 12.1, but I need to double check)

The problem in my pytorch PR is that I am trying to do it hands-off and the build is getting confused* (i.e. told by macos-12 to set up sdk12.3 but told by conda-forge to set up sdk11.0, so the headers, etc are all over the place --- I could tidy it up there, but it would be good to pursue a unified strategy)

*confused because it is deciding certain cmake/make args based on the availability of sdks