Closed isuruf closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Thanks @isuruf, that's great!
I guess one thing we have to think about is how to square this with the zip (in the current migrator) that pulls in a specific docker-image. On the arrow-feedstock I worked around this with a commit such as https://github.com/conda-forge/arrow-cpp-feedstock/pull/859/commits/61be7392b443f75ee4af92fc4cce5423ddcafbd7, but I think a more proper solution would be https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/3624
@isuruf, lemme know if there's anything I can do to help with this PR
See Keith's comment above
See Keith's comment above
I gave it a shot in #210, but I'm not sure if it's correct; I let it run during the test phase and the CI is green, so it doesn't seem too far off.
Worth noting: the manifest posted by Keith only contains one devel package (cuda-nvml-devel
), whereas this PR so far has:
cuda-cudart-devel-11-2-11.2.72-1\
cuda-driver-devel-11-2-11.2.152-1 \
cuda-nvml-devel-11-2-11.2.67-1 \
cuda-nvrtc-devel-11-2-11.2.152-1 \
libcublas-devel-11-2-11.3.1.68-1 \
libcufft-devel-11-2-10.4.1.152-1 \
libcurand-devel-11-2-10.2.3.152-1 \
libcusolver-devel-11-2-11.1.0.152-1 \
libcusparse-devel-11-2-11.4.1.1152-1 \
libnpp-devel-11-2-11.2.1.68-1 \
libnvjpeg-devel-11-2-11.4.0.152-1
If we need to add those devel packages (most likely necessary to have the headers?!), then that needs more massaging, but shouldn't be too hard.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)cc @jakirkham, @kkraus14, @h-vetinari