Closed ryanvolz closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I don't see RECIPE_ROOT defined anywhere. Are you sure it is defined in the calling process?
I struggle with following how all of the infrastructure is connected, but as far as I understand it: it's defined in the run_docker_build.sh.tmpl
template, mounted into the docker container, then redefined in the container to the volume mount point. Or when docker isn't used, it's defined in the CI template like for drone here.
Ok cc @conda-forge/core can you all double check this?
Lgtm.
Thanks @isuruf!
Checklist
Bumped the build number (if the version is unchanged)0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)This modifies
cross_compile_support.sh
to look foryum_requirements.txt
using the already-set$RECIPE_ROOT
variable instead of$CI_SUPPORT/../recipe/
. It's a bit of an esoteric case, but this fixes installing theyum_requirements.txt
packages into a sysroot when cross-compiling ANDconda-forge.yml
has been configured with a non-standard recipe dir. That in turn fixes running tests onlinux-aarch64
for a non-conda-forge package that useslibgl.so.1
where I'm using conda-smithy to provide CI.I tested this by building my own
conda-forge-ci-setup
package with this change and using it with theremote_ci_setup
key inconda-forge.yml
for the aforementioned package.