conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 51 forks source link

Fix finding yum_requirements.txt when recipe dir is non-standard #222

Closed ryanvolz closed 1 year ago

ryanvolz commented 1 year ago

Checklist

This modifies cross_compile_support.sh to look for yum_requirements.txt using the already-set $RECIPE_ROOT variable instead of $CI_SUPPORT/../recipe/. It's a bit of an esoteric case, but this fixes installing the yum_requirements.txt packages into a sysroot when cross-compiling AND conda-forge.yml has been configured with a non-standard recipe dir. That in turn fixes running tests on linux-aarch64 for a non-conda-forge package that uses libgl.so.1 where I'm using conda-smithy to provide CI.

I tested this by building my own conda-forge-ci-setup package with this change and using it with the remote_ci_setup key in conda-forge.yml for the aforementioned package.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ryanvolz commented 1 year ago

I don't see RECIPE_ROOT defined anywhere. Are you sure it is defined in the calling process?

I struggle with following how all of the infrastructure is connected, but as far as I understand it: it's defined in the run_docker_build.sh.tmpl template, mounted into the docker container, then redefined in the container to the volume mount point. Or when docker isn't used, it's defined in the CI template like for drone here.

beckermr commented 1 year ago

Ok cc @conda-forge/core can you all double check this?

Lgtm.

beckermr commented 1 year ago

Thanks @isuruf!