conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 51 forks source link

Support macOS SDK 12.3 #228

Closed isuruf closed 1 year ago

isuruf commented 1 year ago

Checklist

Fixes https://github.com/conda-forge/conda-forge-ci-setup-feedstock/issues/227

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hmaarrfk commented 1 year ago

how do you find these SDKs downloads?

isuruf commented 1 year ago

Can't remember. Was a long time ago.

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

hmaarrfk commented 1 year ago

Did we need to update the build number?

isuruf commented 1 year ago

Ah yes, we need to update the version

hmaarrfk commented 1 year ago

I guess i didn't review too hard since you had added automerge.

hmaarrfk commented 1 year ago

Do you want to just edit the main branch?

beckermr commented 1 year ago

Calver like the pinnings repo?

isuruf commented 1 year ago

https://github.com/conda-forge/conda-forge-ci-setup-feedstock/pull/229

isuruf commented 1 year ago

I'd rather not. It makes the recipe not reproducible.

ngam commented 1 year ago

@isuruf I appreciate your quick solution. We will want a more permanent solution eventually. We could try to redistribute these SDKs ourselves one day (if licensing allows) in a feedstock or something

isuruf commented 1 year ago

We could try to redistribute these SDKs ourselves one day (if licensing allows)

Licensing situation will never improve.

ngam commented 1 year ago

I love isuruf the cynic and isuruf in general ❤️