conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 51 forks source link

fix untarring osx SDKSs from recent PR #230

Closed ngam closed 1 year ago

ngam commented 1 year ago

following #228 and #229 xref https://github.com/conda-forge/pytorch-cpu-feedstock/pull/162

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ngam commented 1 year ago

@conda-forge-admin, please rerender

ngam commented 1 year ago

cc @isuruf @hmaarrfk

# for 12.3 we need to remove "sdk" from the filename
-tar -xf MacOSX${MACOSX_SDK_VERSION}.sdk.tar.xz -C "$(dirname "$CONDA_BUILD_SYSROOT")"
+tar -xf MacOSX${MACOSX_SDK_VERSION}.tar.xz -C "$(dirname "$CONDA_BUILD_SYSROOT")"
github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-ci-setup-feedstock/actions/runs/4097560631.

hmaarrfk commented 1 year ago

Can we speicfy the --output parameter instead? it seems they on the .sdk.tar.gz and we should just pick one for our script.

https://curl.se/docs/manpage.html#-o

isuruf commented 1 year ago

Yeah, --output seems like the better option

hmaarrfk commented 1 year ago

Is the minor version bump appropriate. or should we just update the patch version?

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!