search

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 50 forks source link

Allow cross-compilation with CUDA 12 #250

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

Trying to use CUDA 12 in https://github.com/conda-forge/arrow-cpp-feedstock/pull/1120, and it fails unsurprisingly because the branches here make it so.

Also picking up a minor comment improvement from #236

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 1 year ago

So this is doing the minimal changes of just not erroring out on CUDA 12 now. In an ideal world, that's all we need. It's possible we still have to iterate a bit, but since no-one is cross-compiling with CUDA 12 yet, this has no risk of breakage, so I'm putting it in. :)

jakirkham commented 1 year ago

Think we also need to bump the version number

https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/679cbdce93607a3c76b578165d60b6b67ad8ac75/recipe/meta.yaml#L2

h-vetinari commented 1 year ago

Gah, sorry for missing that. 😑

jakirkham commented 1 year ago

All good. This feedstock is a bit of a weird one

h-vetinari commented 1 year ago

https://github.com/conda-forge/conda-forge-ci-setup-feedstock/commit/17fd53570288308428591cd8c6b04c95a8a70367

Clearly my coffee hasn't kicked in yet. Apologies again.

jakirkham commented 1 year ago

Looks good. Thanks! 🙏

Other people have missed the same thing before (self included). So wouldn't worry about it

Curious to see how this goes 🙂