Closed jakirkham closed 10 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Thanks Axel! 🙏
Appreciate the helpful tips. Have tried to push some changes to address those
Please let me know how that looks
CI is failing as the nvcc
wrapper script package has not been built for CUDA 11.8 cross-compilation
Addressing with PR: https://github.com/conda-forge/nvcc-feedstock/pull/99
Tried to merge main here after #265, but it seem you've unchecked the box that says "allow edits by maintainers"
Thanks Axel! 🙏
Unfortunately since this is an org fork (as opposed to a user fork) that check box isn't even available (I couldn't check it if I wanted to)
Have clicked the update branch button. So we should be good to go
Also FWIW closing and reopening PRs has the same effect (it deletes the merge ref for the PR and recreates it using the latest upstream branch), which will also update what CI builds from as a result
Ah, I had forgotten that this depends on https://github.com/conda-forge/nvcc-feedstock/pull/99. 🙃
Yeah no worries. This wound up being a bit of a yak shave (though that was mostly expected)
It looks like this is going to need
azure:
free_disk_space: true
in conda-forge.yml
to test this.
I did this in #267 and it's passing! 🥳
If we do not want to keep the cross-compilation jobs (which would be purely for testing purposes), then you could rebase/revert out the migrator and merge this from my POV. 👍
Thanks Axel! 🙏
Went ahead and cherry-picked the last 2 commits. Hope that is ok
Hi! This is the friendly conda-forge automerge bot!
I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day!
Forgot to bump version 🤦♂️
Fixed with commit: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/commit/22b4448b3d9feda2f78f94149b68a015366c3a9e
This adds additional logic to the CUDA 11 cross-compilation case here to support CUDA 11.8.
Needed as part of the CUDA 11.8 migration: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/4834
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)