conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 50 forks source link

Add CUDA 11.8 cross-compilation support #261

Closed jakirkham closed 10 months ago

jakirkham commented 10 months ago

This adds additional logic to the CUDA 11 cross-compilation case here to support CUDA 11.8.

Needed as part of the CUDA 11.8 migration: https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/4834


Checklist

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 10 months ago

Thanks Axel! 🙏

Appreciate the helpful tips. Have tried to push some changes to address those

Please let me know how that looks

jakirkham commented 10 months ago

CI is failing as the nvcc wrapper script package has not been built for CUDA 11.8 cross-compilation

Addressing with PR: https://github.com/conda-forge/nvcc-feedstock/pull/99

h-vetinari commented 10 months ago

Tried to merge main here after #265, but it seem you've unchecked the box that says "allow edits by maintainers"

jakirkham commented 10 months ago

Thanks Axel! 🙏

Unfortunately since this is an org fork (as opposed to a user fork) that check box isn't even available (I couldn't check it if I wanted to)

Have clicked the update branch button. So we should be good to go

Also FWIW closing and reopening PRs has the same effect (it deletes the merge ref for the PR and recreates it using the latest upstream branch), which will also update what CI builds from as a result

h-vetinari commented 10 months ago

Ah, I had forgotten that this depends on https://github.com/conda-forge/nvcc-feedstock/pull/99. 🙃

jakirkham commented 10 months ago

Yeah no worries. This wound up being a bit of a yak shave (though that was mostly expected)

h-vetinari commented 10 months ago

It looks like this is going to need

azure:
  free_disk_space: true

in conda-forge.yml to test this.

h-vetinari commented 10 months ago

I did this in #267 and it's passing! 🥳

If we do not want to keep the cross-compilation jobs (which would be purely for testing purposes), then you could rebase/revert out the migrator and merge this from my POV. 👍

jakirkham commented 10 months ago

Thanks Axel! 🙏

Went ahead and cherry-picked the last 2 commits. Hope that is ok

github-actions[bot] commented 10 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

jakirkham commented 10 months ago

Forgot to bump version 🤦‍♂️

Fixed with commit: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/commit/22b4448b3d9feda2f78f94149b68a015366c3a9e