conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 53 forks source link

Fix Thrust missing in Windows CI since CUDA 11.4 #273

Closed leofang closed 1 year ago

leofang commented 1 year ago

Checklist

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 1 year ago

@conda-forge/core this is ready

cc @jakirkham @h-vetinari

jaimergp commented 1 year ago

Isn't this the same as thrust-feedstock? ... and isn't that archived? Why is this needed now?

leofang commented 1 year ago

Isn't this the same as thrust-feedstock?

@jaimergp No it's not. This is like an incomplete CUDA 11 docker image, but for Windows.

In Linux (or Windows + CUDA 11.2), the full CTK comes with Thrust headers. Now that we switch to the 11.8 migrator, the Windows CI fails because Thrust becomes a separate component to be extracted from the installer. Please see the above CuPy 11.8 migration PR for the CI failure.

leofang commented 1 year ago

@conda-forge/core Friendly nudge. This is blocking the CUDA 11.8 migration (https://github.com/conda-forge/cupy-feedstock/pull/226).

github-actions[bot] commented 1 year ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!