Add all channel_sources

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 50 forks source link

Add all channel_sources #279

Closed 0xbe7a closed 9 months ago

0xbe7a commented 9 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

As part of the python312 migration we are zipping channel_sources with the python. Thus we might have recipes, that have multiple different channel_sources. We need to add all of them to the conda config.

https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/6c10ede00fca334a2df2e4da90455d40cb4e5592/recipe/migrations/python312.yaml#L32

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

0xbe7a commented 9 months ago

I see. I face this issue with brotli-feedstock, where there are no separate variants for each Python version.

I can't think of any way to get this work to work with a single variant, channel_priority strict and zipped channel_sources. How would you go about it?

0xbe7a commented 9 months ago

@Isuruf i removed the formatting changes

xhochy commented 9 months ago

CI is failing but it does look more like a general problem: conda-forge is no longer listed as a channel in the .condarc.

@0xbe7a Can you merge main/rebase?

github-actions[bot] commented 9 months ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

xhochy commented 9 months ago

@0xbe7a Nope, this is probably related to your change.

github-actions[bot] commented 9 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!