Add support for MacOS 13.3 SDK - Githubissues

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 50 forks source link

Add support for MacOS 13.3 SDK #281

Closed bollwyvl closed 9 months ago

bollwyvl commented 9 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

References:

fixes #264

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

bollwyvl commented 9 months ago

I don't know much about this repo... anything else what needs doing? Tests?

isuruf commented 9 months ago

Can you add a recipe/conda_build_config.yaml with MACOSX_SDK_VERSION: 13.3 and rerender? Then we should be able to see if it works.

bollwyvl commented 9 months ago

@conda-forge-admin please rerender

bollwyvl commented 9 months ago

Looks like it did the thing:

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=786578&view=logs&j=15f8dc28-9f6f-5e3a-5b3c-2b169071e5be&t=63fa899e-c160-5185-75c4-c5fd30c90374&l=346

So presumably now remove that, and rerender?

bollwyvl commented 9 months ago

Should i be worried about the remaining changes? Just hard revert back to fcafa88 ?

beckermr commented 9 months ago

They look fine to me!

bollwyvl commented 9 months ago

Thanks!