Support CUDA 12 + Windows

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 50 forks source link

Support CUDA 12 + Windows #292

Closed leofang closed 8 months ago

leofang commented 8 months ago

The logic here is to treat CUDA 12+ differently from previous CUDA versions. Specifically, for CUDA 12+ we

do not download/extract any CUDA installer
do not need to set CUDA_PATH or update PATH
but still need to set CONDA_OVERRIDE_CUDA

Tested in https://github.com/conda-forge/cupy-feedstock/pull/228.

cc: @conda-forge/cuda

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 8 months ago

Think we might need to update these lines as well

Edit: Specifically looking at CONDA_OVERRIDE_CUDA, which we would still set

https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/fe41924428086877a6936f46d5901bd921202f98/recipe/run_conda_forge_build_setup_win.bat#L130-L135

leofang commented 8 months ago

Yes, this block is only reachable by CUDA 11 and below (where CUDA_PATH is set). For CUDA 12+, this block would be skipped. It's admitted an ugly hack, but my lack of cmd knowledge (and failures to make CI happy even with correct code, as noted above) is preventing me from doing a better job here.

jakirkham commented 8 months ago

Ah gotcha. May just be my fault for looking on my phone

jakirkham commented 8 months ago

@conda-forge/core , any other thoughts on this change?

jakirkham commented 8 months ago

Thanks all! 🙏

Let's give this a try and follow up on anything else after

Note: Missed we didn't have the version number bump. So did that in commit ( https://github.com/conda-forge/conda-forge-ci-setup-feedstock/commit/902a2beabaff6fd0b912f490744f6f016131c12b )

leofang commented 8 months ago

Thanks for catching the version bump, John. Sent a backport PR (#293).