Closed isuruf closed 10 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Do you really want to support a variable that is sometimes a string, sometimes a boolean?
On the linux code path we have:
33 if [ -f ${CI_SUPPORT}/${CONFIG}.yaml ]; then
34 echo "CMAKE_CROSSCOMPILING_EMULATOR: " >> ${CI_SUPPORT}/${CONFIG}.yaml
35 echo "- /usr/bin/qemu-${HOST_PLATFORM_ARCH}-static" >> ${CI_SUPPORT}/${CONFIG}.yaml
36 echo "CROSSCOMPILING_EMULATOR: " >> ${CI_SUPPORT}/${CONFIG}.yaml
37 echo "- /usr/bin/qemu-${HOST_PLATFORM_ARCH}-static" >> ${CI_SUPPORT}/${CONFIG}.yaml
38 fi
I agree that it's confusing. However, we usually test that it is non-empty on Linux too. CMake use CMAKE_CROSSCOMPILING_EMULATOR
to launch binaries, but I'm not setting it here because I couldn't think of what to set here. The emulator is called by the OS itself so there's no path for it.
Understood on the non-emptiness front. Is the following suggestion possible: https://github.com/conda-forge/conda-smithy/pull/1808#discussion_r1405507116
This is tested on CI here.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)