`validate_recipe_outputs` failing due to missing `conda_build.config.subdir` (conda-build 24.5.0?)

[jakirkham]

Seeing the following error in this CI log (also attached log):

+ validate_recipe_outputs cuda-sanitizer-api-feedstock
Traceback (most recent call last):
  File "/opt/conda/bin/validate_recipe_outputs", line 11, in <module>
    sys.exit(main())
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/conda_forge_ci_setup/feedstock_outputs.py", line 165, in main
    for p in os.listdir(os.path.join(conda_build.config.croot, conda_build.config.subdir))  # noqa
  File "/opt/conda/lib/python3.10/site-packages/conda_build/deprecations.py", line 301, in __getattr__
    raise AttributeError(f"module '{fullname}' has no attribute '{name}'")
AttributeError: module 'conda_build.config' has no attribute 'subdir'

Relevant code paths:

https://github.com/conda-forge/conda-forge-ci-setup-feedstock/blob/3b9904b4213a7fe442588d66bca4651ef92aeacd/recipe/conda_forge_ci_setup/feedstock_outputs.py#L164-L165

[jakirkham]

Am seeing this in all other recent builds (for example)

Think we may want to pull conda-build version 24.5.0 or constrain our tooling until we have an opportunity to fix this properly

cc @conda-forge/core

[jakirkham]

Actually maybe we just need this fix extended ( https://github.com/conda-forge/conda-forge-ci-setup-feedstock/pull/305 )?

[jakirkham]

Pushed a potential fix: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/pull/318

Though it is possible that it also won't deploy until this issue is resolved

So think we still will need to mark broken conda-build version 24.5.0 (possibly also conda version 24.5.0). Then review and deploy the fix. And then mark unbroken conda & conda-build version 24.5.0

[beckermr]

It will deploy. The feedstock here uses the local copy of ci setup to bootstrap properly.

[jakirkham]

Know that is true of some scripts, but wasn't sure whether that was true of package validation

In any event happy to try the fix first

If we are still seeing issues, think we should just mark conda & conda-build version 24.5.0 broken for now and revisit in the morning. Put together a PR to do that: https://github.com/conda-forge/admin-requests/pull/995

[beckermr]

It's true of everything provided by ci setup.

[beckermr]

Well shit the bootstrapping is broken again. Wtf? Will fix by hand.

[beckermr]

It's not the bootstrapping. We missed more old apis. I'll push a new pr.

[jakirkham]

Looks like the issue is in the upload_or_check_non_existence script

From CI:

Traceback (most recent call last):
  File "/opt/conda/bin/upload_package", line 8, in <module>
    sys.exit(upload_package())
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/conda/lib/python3.10/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/opt/conda/lib/python3.10/site-packages/conda_forge_ci_setup/build_utils.py", line 247, in upload_package
    retry_upload_or_check(
  File "/opt/conda/lib/python3.10/site-packages/conda_forge_ci_setup/upload_or_check_non_existence.py", line 349, in retry_upload_or_check
    raise TimeoutError("Did not manage to upload package.  Failing.")
TimeoutError: Did not manage to upload package.  Failing.

[jakirkham]

Submitted PR: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/pull/319

Not seeing any others of this form

If there are different issues, we may need to talk to others familiar with the upstream deprecations

[jakirkham]

Am seeing new builds on main starting to pass. So think this is resolving itself

[jakirkham]

For tracking/visibility, filed a status issue: https://github.com/conda-forge/status/issues/177

[jaimergp]

Thank you both! <3