conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.
BSD 3-Clause "New" or "Revised" License
13 stars 53 forks source link

Fix `conda_build.config.subdir` deprecation #318

Closed jakirkham closed 4 months ago

jakirkham commented 4 months ago

Fixes https://github.com/conda-forge/conda-forge-ci-setup-feedstock/issues/317

Checklist

xref: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/pull/305

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 4 months ago

@conda-forge-admin , please re-render

github-actions[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the fix_conda_build_subdir_dep branch of jakirkham-feedstocks/conda-forge-ci-setup-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: Our webservices cannot push to PRs from organization accounts or PRs from forks made from organization forks because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-forge-ci-setup-feedstock/actions/runs/9071658113.

jakirkham commented 4 months ago

Tried re-rendering locally. It seems to be changing a bunch of stuff (like dropping CUDA 11.2)

Going to hold off on that so we can focus on getting uploads working. Want to make sure even recently deprecated builds still get the fix

Can revisit after

github-actions[bot] commented 4 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!