Set default MACOSX_DEPLOYMENT_TARGET to 10.13

conda-forge / conda-forge-ci-setup-feedstock

A conda-smithy repository for conda-forge-ci-setup.

BSD 3-Clause "New" or "Revised" License

13 stars 53 forks source link

Set default MACOSX_DEPLOYMENT_TARGET to 10.13 #321

Closed xhochy closed 4 months ago

xhochy commented 4 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 4 months ago

Why this change? Please revert. This change should only come in when feedstocks are rerendered. We talked about this in a core meeting and existing PRs without rerendering should work as before.

xhochy commented 4 months ago

I discovered that staged-recipes was still building with 10.9 as the deployment target. This is one of the approaches to fix. The other one I could think of is https://github.com/conda-forge/staged-recipes/pull/26449

xhochy commented 4 months ago

Revert over here: https://github.com/conda-forge/conda-forge-ci-setup-feedstock/pull/322

beckermr commented 4 months ago

Sorry for the merge! I did not realize!