search

conda-forge / conda-forge-pinning-feedstock

A conda-smithy repository for conda-forge-pinning.
BSD 3-Clause "New" or "Revised" License
58 stars 503 forks source link

tighten pinning for freetype? #214

Open grlee77 opened 5 years ago

grlee77 commented 5 years ago

moving issue conda-forge/freetype-feedstock#28 over here at @ocefpaf 's suggestion.

A user is reporting an issue with VTK (conda-forge/vtk-feedstock#80) when freetype 2.10 is used. The issue seeems to be that freetype 2.10 can be installed with a VTK that was built against 2.9.1 and apparently these two are incompatible.

The following site seems to indicate changes in symbols between these versions of freetype: https://abi-laboratory.pro/?view=timeline&l=freetype

It looks like freetype is only pinned based on the major version: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/9b8e67fcac4a4199dc7af7f120564aceab1cc7b8/recipe/conda_build_config.yaml#L177-L178

Should we tighten the pinning here? If not, then what is the recommended solution on the VTK end?

ocefpaf commented 5 years ago

Thanks for transferring it here. Do you want to send a PR to change that? Pretty much you have to put a x.x there and update the version we are using for the build in the version line below. Then we can setup a migrator to start issuing PRs to it.

grlee77 commented 5 years ago

Okay, I made a PR, but I'm not sure if I pinged the bot correctly regarding setting up a migration.

CJ-Wright commented 5 years ago

Can we close this issue? It seems that the pin stayed as is.