conda-forge / conda-forge-pinning-feedstock

A conda-smithy repository for conda-forge-pinning.
BSD 3-Clause "New" or "Revised" License
56 stars 501 forks source link

Remaining items for closing qt 5.15 migration #3891

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

Since there was no consensus about closing the PRs on abandoned feedstocks in the k*-ecosystem (see here), here's a manual list of the remaining to-dos before closing the qt 5.15 migration.

Status of remaining qt 5.15 PRs

(almost everything shows up in the migrator status; but I also double-checked with the recently much-improved GH search)

Ready to merge

To do

Feedstocks that still pin to qt < 5.15

(sidenote: loving the new GH search functionality 🤩 )

Abandoned / Obsolete Packages

All in all, it looks like there's barely a handful feedstocks left in order to be able to close this.

CC @conda-forge/qt-main

hmaarrfk commented 1 year ago

I am proposing we update the pinnings for now, and leave the migration open https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/4442

hmaarrfk commented 1 year ago

I'm not too sure about pyqtads. I remember I helped on that one due to it being stuck for some strange reason at the time.

h-vetinari commented 1 year ago

I am proposing we update the pinnings for now, and leave the migration open

I'm much in favour of updating the pinnings. I'd close the migration, as these packages are (with perhaps 2-3 exceptions) simply not being updated anymore. And as soon as someone picks them up again and rerenders, they get the new pinnings anyway.

That said, I don't really care if the migration stays open, as long as we can move forward (i.e. qt6 soon, as you mentioned in #4442).

hmaarrfk commented 1 year ago

Since i made the PR #4442 i had a chance to go through your notes more thoroughly, and they are quite complete. I think we should just merge and move forward. I'll close the migration in #4442

h-vetinari commented 1 year ago

This was closed by https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/4442