create geotiff 1.7.3 migrator

conda-forge / conda-forge-pinning-feedstock

A conda-smithy repository for conda-forge-pinning.

BSD 3-Clause "New" or "Revised" License

54 stars 480 forks source link

create geotiff 1.7.3 migrator #6124

Closed akrherz closed 2 weeks ago

akrherz commented 2 weeks ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

As with #2676, we seem to need to create a manual migrater for geotiff.

c/f conda-forge/gdal-feedstock#956

conda-forge-webservices[bot] commented 2 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 2 weeks ago

@conda-forge/geotiff, any concerns? It seems we need this before https://github.com/conda-forge/conda-forge-pinning-feedstock/pull/5998 will be useful.

hmaarrfk commented 2 weeks ago

does it make sense to migrate both at the same time?

xylar commented 2 weeks ago

@hmaarrfk, I don't think so, I think we just need this one to happen first for any packages that happen to depend on both. The tangling up is related to proj, not to libgeotiff or geos directly.

hmaarrfk commented 2 weeks ago

or any packages that happen to depend on both

I mean, adding a few lines to the migrator would save you time and effort IMO. but ok! here goes!

Something to consider for next time!

xylar commented 2 weeks ago

@hmaarrfk, you have more experience tying migrations together than me. I'm happy to defer to you in the future. I just thought it would cause confusion.

hmaarrfk commented 2 weeks ago

i mean, it would be new to me as well, just trying to see if we can avoid churn you know!