search

conda-forge / conda-forge-webservices

the web app deployed to run conda-forge admin commands and linting
BSD 3-Clause "New" or "Revised" License
8 stars 35 forks source link

Add emojis to visually distinguish between hints and lints #770

Closed maresb closed 3 weeks ago

maresb commented 3 weeks ago

Description

As I explain here it can be really easy to miss the distinction between hints and linting errors. (The difference is indicated in a big block of boilerplate text.) Using :information_source: for hints and :x: for linter errors, I hope to make this easier to understand the severity at a glance.

maresb commented 3 weeks ago

cc @beckermr

maresb commented 3 weeks ago

pre-commit.ci autofix

beckermr commented 3 weeks ago

This will potentially break some spacing hacks in hints with sub lists. Is there a way we can account for that with the emoji?

maresb commented 3 weeks ago

Hmm, can you point to an example so that I understand better?

beckermr commented 3 weeks ago

See this link: https://github.com/conda-forge/conda-smithy/pull/2126. I used a precise number of spaces to format things properly.

beckermr commented 3 weeks ago

Also there are two linting paths. The one in use is the one in the GitHub actions integration submodule. We'll want to change that one too.

maresb commented 3 weeks ago

Thanks @beckermr! Regarding the sublists I think it still works without modification. I tested <SP>*<SP><EMOJI><SP><NL><SP><SP><SP>- ... here.

maresb commented 3 weeks ago

Also there are two linting paths. The one in use is the one in the GitHub actions integration submodule. We'll want to change that one too.

Thanks, got it in f79e381