Closed jakirkham closed 8 years ago
Some discussion points came up in the hackpad I am adding them here with some points that came to mind so that I don't forget them.
scikit-learn
approaches this problem. They suggest adding WIP
to PRs still being worked on, MRG
to PRs that are ready for thorough review, and MRG+1
to PRs that have been reviewed and have at least one LGTM. ( https://github.com/scikit-learn/scikit-learn/blob/master/CONTRIBUTING.md#contributing-pull-requests )I added the topics to the next meeting agenda and I would like to discuss there first. before opening any issue here or anywhere. I'd appreciate if you could understand that @jakirkham as there are sensitive issues I want to bring that are not appropriate for discussion here.
This has come up in a few places and I think it would be helpful to have a discussion somewhere. So, I have opened this issue. Feel free to add any thoughts you would like here.