search

conda-forge / conda-forge.github.io

The conda-forge website.
https://conda-forge.org
BSD 3-Clause "New" or "Revised" License
128 stars 275 forks source link

Separate linkcheck to a different job from deploy #1715

Closed jakirkham closed 7 months ago

jakirkham commented 2 years ago

We've had linkcheck running for a bit. Generally this seems useful. That said, we have had a few cases recently ( https://github.com/conda-forge/conda-forge.github.io/issues/1663 ) ( https://github.com/conda-forge/conda-forge.github.io/pull/1710 ) where linkcheck caused deployment to fail. Given this, would like to suggest we break linkcheck out into a separate GH Actions job. This way if it fails it will be clearer that linkcheck in particular is failing and separate it from the deployment process (especially if we need to get a doc fix out while the linkcheck issue is triaged).

beckermr commented 7 months ago

With the new webpage we no longer have this issue.

jakirkham commented 7 months ago

Do we still check the validity of links?

beckermr commented 7 months ago

Yes it is done in docusarus