conda-forge / conda-smithy-feedstock

A conda-smithy repository for conda-smithy.
BSD 3-Clause "New" or "Revised" License
4 stars 27 forks source link

Use `m2-git` on Windows #277

Closed jakirkham closed 5 months ago

jakirkham commented 9 months ago

The git package on Windows is binary repackaged from upstream. However it includes some MSYS2 bits in itself ( https://github.com/conda-forge/git-feedstock/issues/135 ), which clobber other MSYS2 packages we might use. To address this, switch to m2-git on Windows.


Checklist

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

beckermr commented 9 months ago

As it stands now the build makes to artifacts with identical build numbers and different hashes. At minimum, it'd be advisable to put win vs unix in the build string so people can understand the difference.

isuruf commented 9 months ago

This recipe follows docs at https://conda-forge.org/docs/maintainer/knowledge_base.html#noarch-packages-with-os-specific-dependencies .

If you think that's wrong, maybe open an issue in website repo?

jakirkham commented 9 months ago

@beckermr , please see this doc

Edit: Isuru was faster 😅 Thanks Isuru! 🙏

beckermr commented 9 months ago

Ohhhhhhh my apologies everyone! Thank you for pointing that out. I still think the build string change would be helpful to others, but otherwise LGTM!

jakirkham commented 5 months ago

@conda-forge-admin , please re-render

github-actions[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like I wasn't able to push to the use_m2-git_win branch of jakirkham-feedstocks/conda-smithy-feedstock. Did you check the "Allow edits from maintainers" box?

NOTE: Our webservices cannot push to PRs from organization accounts or PRs from forks made from organization forks because of GitHub permissions. Please fork the feedstock directly from conda-forge into your personal GitHub account.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-smithy-feedstock/actions/runs/9186003690.

jakirkham commented 5 months ago

@conda-forge-admin , please re-render

github-actions[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-smithy-feedstock/actions/runs/9186045758.

h-vetinari commented 5 months ago

FWIW, for me this broke having git understand remote references (showing where HEAD and other remote branches are when doing git log).

beckermr commented 5 months ago

That is rather confusing to me. Is m2-git on windows broken?

h-vetinari commented 5 months ago

Possibly. Here's an example of the difference:

Without m2-git (== situation before this PR even with an activated environment):

image

After this PR:

image

My builder environment contains smithy; not only are branch heads not shown anymore, but apparently tags are affected too.

beckermr commented 5 months ago

Ouch. @jakirkham @isuruf @xhochy any ideas or comments here?

jakirkham commented 5 months ago

Does this have something to do with where m2-git looks for .gitconfig or perhaps the version of git used?