Closed beckermr closed 5 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Looking at https://github.com/conda-forge/conda-smithy/blame/main/environment.yml, we need something like the following here:
--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -30,13 +30,14 @@ requirements:
- python >=3.6
- setuptools
- conda >=4.2
- - conda-build >=3.18.3
+ - conda-build >=24.3
- conda-package-handling >=1.9.0
- jinja2
- requests
- pycryptodome
- gitpython
- git
+ - pydantic >=2,<3
- pygithub >=2,<3
- ruamel.yaml >=0.16
- conda-forge-pinning
@@ -46,7 +47,9 @@ requirements:
- license-expression
- libarchive
- tomli >=1.0.0 # for python <3.11, can remove in the future
+ - backports.strenum
- cirun >=0.30
+ - exceptiongroup
- jsonschema
run_constrained:
# For more details about `shellcheck`, please see this issue.
We also might want to sort the runtime dependencies alphabetically...
I am pretty sure pydantic is not a runtime dep. @isuruf has been keeping track of that and should be able to say.
exception group appears to be optional as well?
the relevant code section is
try:
from builtins import ExceptionGroup
except ImportError:
from exceptiongroup import ExceptionGroup
exception group appears to be optional as well?
No that just means it'll use the 3.11 builtin if available, and fall back to the backport otherwise (which needs to be there, or we fail also in the except:
branch).
Merge only after success.
This pull request was auto-generated by rever