conda-forge / conda-smithy-feedstock

A conda-smithy repository for conda-smithy.
BSD 3-Clause "New" or "Revised" License
4 stars 27 forks source link

conda-smithy 3.35.0 #287

Closed beckermr closed 5 months ago

beckermr commented 5 months ago

Merge only after success.

This pull request was auto-generated by rever

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 5 months ago

Looking at https://github.com/conda-forge/conda-smithy/blame/main/environment.yml, we need something like the following here:

--- a/recipe/meta.yaml
+++ b/recipe/meta.yaml
@@ -30,13 +30,14 @@ requirements:
     - python >=3.6
     - setuptools
     - conda >=4.2
-    - conda-build >=3.18.3
+    - conda-build >=24.3
     - conda-package-handling >=1.9.0
     - jinja2
     - requests
     - pycryptodome
     - gitpython
     - git
+    - pydantic >=2,<3
     - pygithub >=2,<3
     - ruamel.yaml >=0.16
     - conda-forge-pinning
@@ -46,7 +47,9 @@ requirements:
     - license-expression
     - libarchive
     - tomli >=1.0.0  # for python <3.11, can remove in the future
+    - backports.strenum
     - cirun >=0.30
+    - exceptiongroup
     - jsonschema
   run_constrained:
     # For more details about `shellcheck`, please see this issue.

We also might want to sort the runtime dependencies alphabetically...

beckermr commented 5 months ago

I am pretty sure pydantic is not a runtime dep. @isuruf has been keeping track of that and should be able to say.

beckermr commented 5 months ago

exception group appears to be optional as well?

the relevant code section is

try:
    from builtins import ExceptionGroup
except ImportError:
    from exceptiongroup import ExceptionGroup
h-vetinari commented 5 months ago

exception group appears to be optional as well?

No that just means it'll use the 3.11 builtin if available, and fall back to the backport otherwise (which needs to be there, or we fail also in the except: branch).