conda-forge / conda-smithy-feedstock

A conda-smithy repository for conda-smithy.
BSD 3-Clause "New" or "Revised" License
4 stars 27 forks source link

Breakage with `m2-git` #290

Open h-vetinari opened 5 months ago

h-vetinari commented 5 months ago

Aside from losing tags and branch heads in places like git log (see discussion post-merge in #277), I'm now running into another error:

git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git rm --cached -- ci_support\upload_or_check_non_existence.py
  stderr: 'fatal: pathspec 'ci_support\upload_or_check_non_existence.py' did not match any files'

There's a missing period before "ci_support"; no idea though where the processing goes wrong.

Downgrading smithy to the _0 build of smithy 3.36.0 didn't fix things (neither the error, nor the tag visibility), but that didn't get rid of the new m2-* packages that _1 had dragged in (and conda install --revision <X> didn't resolve for 15min, so I gave up). However, after recreating the environment from scratch, the rerender works again. So it's the mere presence of some of the following libs that breaks things.

``` 2024-05-23 22:10:20 (rev 35) conda-smithy {3.36.0 (conda-forge/noarch) -> 3.36.0 (conda-forge/noarch)} +m2-bash-4.3.042 (conda-forge/win-64) +m2-ca-certificates-20150426 (conda-forge/win-64) +m2-coreutils-8.25 (conda-forge/win-64) +m2-curl-7.47.1 (conda-forge/win-64) +m2-db-5.3.28 (conda-forge/win-64) +m2-expat-2.1.1 (conda-forge/win-64) +m2-findutils-4.6.0 (conda-forge/win-64) +m2-gcc-libs-5.3.0 (conda-forge/win-64) +m2-gdbm-1.11 (conda-forge/win-64) +m2-git-2.8.1 (conda-forge/win-64) +m2-gmp-6.1.0 (conda-forge/win-64) +m2-gzip-1.7 (conda-forge/win-64) +m2-heimdal-1.5.3 (conda-forge/win-64) +m2-heimdal-libs-1.5.3 (conda-forge/win-64) +m2-icu-56.1 (conda-forge/win-64) +m2-info-6.0 (conda-forge/win-64) +m2-less-481 (conda-forge/win-64) +m2-libcrypt-1.3 (conda-forge/win-64) +m2-libcurl-7.47.1 (conda-forge/win-64) +m2-libdb-5.3.28 (conda-forge/win-64) +m2-libedit-3.1 (conda-forge/win-64) +m2-libexpat-2.1.1 (conda-forge/win-64) +m2-libffi-3.2.1 (conda-forge/win-64) +m2-libgdbm-1.11 (conda-forge/win-64) +m2-libiconv-1.14 (conda-forge/win-64) +m2-libidn-1.32 (conda-forge/win-64) +m2-libintl-0.19.7 (conda-forge/win-64) +m2-libmetalink-0.1.2 (conda-forge/win-64) +m2-libopenssl-1.0.2.g (conda-forge/win-64) +m2-libp11-kit-0.23.2 (conda-forge/win-64) +m2-libpcre-8.38 (conda-forge/win-64) +m2-libreadline-6.3.008 (conda-forge/win-64) +m2-libsqlite-3.10.0.0 (conda-forge/win-64) +m2-libssh2-1.6.0 (conda-forge/win-64) +m2-libtasn1-4.7 (conda-forge/win-64) +m2-ncurses-6.0.20160220 (conda-forge/win-64) +m2-openssh-7.1p2 (conda-forge/win-64) +m2-openssl-1.0.2.g (conda-forge/win-64) +m2-p11-kit-0.23.2 (conda-forge/win-64) +m2-perl-5.22.1 (conda-forge/win-64) +m2-perl-authen-sasl-2.16 (conda-forge/win-64) +m2-perl-convert-binhex-1.123 (conda-forge/win-64) +m2-perl-encode-locale-1.04 (conda-forge/win-64) +m2-perl-error-0.17024 (conda-forge/win-64) +m2-perl-file-listing-6.04 (conda-forge/win-64) +m2-perl-html-parser-3.71 (conda-forge/win-64) +m2-perl-html-tagset-3.20 (conda-forge/win-64) +m2-perl-http-cookies-6.01 (conda-forge/win-64) +m2-perl-http-daemon-6.01 (conda-forge/win-64) +m2-perl-http-date-6.02 (conda-forge/win-64) +m2-perl-http-message-6.06 (conda-forge/win-64) +m2-perl-http-negotiate-6.01 (conda-forge/win-64) +m2-perl-io-socket-ssl-2.016 (conda-forge/win-64) +m2-perl-io-stringy-2.111 (conda-forge/win-64) +m2-perl-libwww-6.13 (conda-forge/win-64) +m2-perl-lwp-mediatypes-6.02 (conda-forge/win-64) +m2-perl-mailtools-2.14 (conda-forge/win-64) +m2-perl-mime-tools-5.506 (conda-forge/win-64) +m2-perl-net-http-6.09 (conda-forge/win-64) +m2-perl-net-smtp-ssl-1.02 (conda-forge/win-64) +m2-perl-net-ssleay-1.72 (conda-forge/win-64) +m2-perl-termreadkey-2.33 (conda-forge/win-64) +m2-perl-timedate-2.30 (conda-forge/win-64) +m2-perl-uri-1.68 (conda-forge/win-64) +m2-perl-www-robotrules-6.02 (conda-forge/win-64) +m2-sed-4.2.2 (conda-forge/win-64) +m2-vim-7.4.1721 (conda-forge/win-64) +m2-zlib-1.2.8 (conda-forge/win-64) ```

Long-term, I'd like to have a __git package (not necessarily virtual, just something that tells the resolver it's already available locally), which allows me not to drag in the huge git updates all the time.

jakirkham commented 5 months ago

Should we just drop the git package on Windows altogether?

It's unfortunate we don't have a better story for git on Windows

jakirkham commented 5 months ago

Seeing a +1 went ahead and made a PR ( https://github.com/conda-forge/conda-smithy-feedstock/pull/291 ) to drop git on Windows

Please let me know what you think

Happy to discuss other options as well