Run pytest tests

[baszalmstra]

Checklist

• [x] Used a personal fork of the feedstock to propose changes
• [x] Bumped the build number (if the version is unchanged)
• [ ] Reset the build number to 0 (if the version changed)
• [ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
• [x] Ensured the license file is being packaged.

This PR adds running of the pytest to the recipe test section. This is useful so that we can run downstream tests from dependencies to guard against accidental breakage.

I also added pydantic >=2,<3 to the run requirements. This is also the case in the upstream environment.yaml.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

[baszalmstra]

Ouch that is a lot of errors..

[baszalmstra]

I only included specific tests for now. I am unsure why a lot of tests fail but I assume its because the tests do not expect to be run from another repository?

Anyway, I think its still important to be able to run the majority of the tests for downstream tests.

[baszalmstra]

@conda-forge-admin, please rerender

[github-actions[bot]]

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/conda-smithy-feedstock/actions/runs/10006117311.

[beckermr]

Pydantic is not a runtime requirement afaik. Cc @isuruf who knows this better.

[baszalmstra]

There is a specific pytest invocation to use for installed packages. We should try that here.

Would be happy to! Do you know what the invocation is, a quick google didnt tell me much?

[baszalmstra]

Pydantic is not a runtime requirement afaik. Cc @isuruf who knows this better.

Its used here:

https://github.com/conda-forge/conda-smithy/blob/7b0b83038ae6c012c72bc13cca6641fb81dc7e08/conda_smithy/schema.py#L10

I think thats part of the package.

[beckermr]

We currently serialize the schema as json and don't use pydantic at runtime IIRC.

[baszalmstra]

We currently serialize the schema as json and don't use pydantic at runtime IIRC.

But then import conda_smithy.schema would just fail right?

[beckermr]

True but I don't think that module is ever impoted at runtime when using smithy.

[beckermr]

See here:

https://github.com/search?q=repo%3Aconda-forge%2Fconda-smithy%20conda_smithy.schema&type=code

this is by design AFAIK. Other members of @conda-forge/core should confirm or deny.

[baszalmstra]

See here:

github.com/search?q=repo:conda-forge/conda-smithy%20conda_smithy.schema&type=code

this is by design AFAIK. Other members of @conda-forge/core should confirm or deny.

I wonder why that would be by design because that seems like bad practice. I can imagine it is used just to generate the JSON schema but I dont think it belongs inside the package in that case.

But I would happy to remove it, Ill wait for someone from core to reply.

[beckermr]

I do not want to rehash the pydantic issue since it has been an ongoing thing. I doubt this PR will get merged until it is removed.

[conda-forge-webservices[bot]]

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

[baszalmstra]

I do not want to rehash the pydantic issue since it has been an ongoing thing. I doubt this PR will get merged until it is removed.

Ok! I moved it to the test section instead.

[github-actions[bot]]

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

• linter: passed
• azure: passed

Thus the PR was passing and merged! Have a great day!