Open ReimarBauer opened 4 years ago
I did a syntax failure adding my name to recipe-maintainers missing the - Afterwards I did a conda smithy rerender and send a pull request.
-
conda smithy rerender
https://github.com/conda-forge/skyfield-feedstock/pull/33/commits/c73c38d82b42b10cfd2f1af46f11cdfa78cc09fe
At this time the linter told me about the mistake.
A feature request may be to run the linter before rerender locally.
A feature request may be to also give the hint after fixing this failure to run conda smithy rerender again. Because this failure changes the maintainer name in README.md https://github.com/conda-forge/skyfield-feedstock/pull/33/commits/f7666921a562303fd6bbad63c7bfc60f8a81f97c
May be the linter can also verify that the maintainer name from the meta.yaml matches the rerendered version in the README.md
I learned by this now, that I whatever I want to push, also if I only fix a typo that I afterwards better rerender again.
This is would be nice to have! PRs welcome!
I did a syntax failure adding my name to recipe-maintainers missing the
-
Afterwards I did aconda smithy rerender
and send a pull request.https://github.com/conda-forge/skyfield-feedstock/pull/33/commits/c73c38d82b42b10cfd2f1af46f11cdfa78cc09fe
At this time the linter told me about the mistake.
A feature request may be to run the linter before rerender locally.
A feature request may be to also give the hint after fixing this failure to run conda smithy rerender again. Because this failure changes the maintainer name in README.md https://github.com/conda-forge/skyfield-feedstock/pull/33/commits/f7666921a562303fd6bbad63c7bfc60f8a81f97c
May be the linter can also verify that the maintainer name from the meta.yaml matches the rerendered version in the README.md
I learned by this now, that I whatever I want to push, also if I only fix a typo that I afterwards better rerender again.