conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
146 stars 170 forks source link

optionally make schema validation errors a warning instead of erroring out during rerenders #1879

Closed beckermr closed 4 months ago

beckermr commented 4 months ago

This feature is stopping the bot from making PRs on effected feedstocks. As @isuruf has pointed out, the linter will error on the CI checks anyways, so letting the rerender go through is fine.

At minimum, we can add an optional override to only warn.

jakirkham commented 4 months ago

Yeah warning on re-rendering seems like a better default

Having an option to convert warnings to errors in conda-smithy could be useful, but maybe that is not needed given the linter already errors. If we do add such an option, it would be good to cover on CI (to catch any false positives early)

jaimergp commented 4 months ago

Agreed on this strategy.