conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
146 stars 170 forks source link

ENH: Take into account `stdlib_version` for determining macOS SDK version in `.ci_support/` and cf-ci-setup #1884

Closed h-vetinari closed 4 months ago

h-vetinari commented 4 months ago

With the introduction of {{ stdlib("c") }} and macosx_deployment_target, we have a new & better way to specify the required macosx deployment target. However, that means if people change to the new way, we need to take that into account when setting up the CI image (i.e. download_osx_sdk.sh in the ci-setup).

Additionally, we should warn about doubly specified deployment targets in cbc.yaml. My suggested proposal is:

Thoughts? @isuruf @mbargull @beckermr

beckermr commented 4 months ago

SGTM!

We probably want to have a linting errors for certain things (like the first bullet point) in addition to smithy warnings.

isuruf commented 4 months ago

Let's do the warning for a few releases and switch to an error.