search

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
146 stars 170 forks source link

add test for correctly resolving stdlib #1888

Closed h-vetinari closed 4 months ago

h-vetinari commented 4 months ago

Closes #1840, ~needs conda-build 24.3; tested locally with artefacts from https://github.com/conda-forge/conda-build-feedstock/pull/220~

h-vetinari commented 4 months ago

I'm actually surprised that this passes with conda-build 24.1.2; I thought that https://github.com/conda/conda-build/pull/5195 would have been necessary, but I guess by adding c_stdlib{,_version} to always_keep_keys, we're not actually dependent on that PR after all... CC @mbargull

jakirkham commented 4 months ago

This is great! Thanks Axel 🙏

mbargull commented 4 months ago

I'm actually surprised that this passes with conda-build 24.1.2; I thought that conda/conda-build#5195 would have been necessary, but I guess by adding c_stdlib{,_version} to always_keep_keys, we're not actually dependent on that PR after all... CC @mbargull

Well, sure, without https://github.com/conda/conda-build/pull/5195, the key is not recognized as used; if you override the logic with the (conda-smithy-specific) always_keep_keys thing, you don't depend on it being recognized, of course.

h-vetinari commented 4 months ago

Yeah, I didn't know the inner workings of conda-{build,smithy} well enough to understand that, sorry...

mbargull commented 4 months ago

Ah, no need to apologize! We needed the fix in conda-build anyway since we have support uses outside of conda-smithy rerender workflows ;).