Open beckermr opened 4 months ago
We really should import the bot schema from the bot repo or something, make it less strict, or w/e. The validation here is hurting more than helping.
TBH, this really depends on how we parse the YAML files.
If we don't use the fail safe schema (i.e., parsing numbers etc.), then it does make sense to have this validation error here rather than having downstream issue from a 11.8 == "11.8"
turning out False
in case the parsed value would later be compared to the actual branch name.
N.B.: My general opinion is that in (almost?) all cases one should parse YAML with the fail safe schema and do any scalar parsing as a separate step afterwards.
I dislike the "magic" from the default/core schema, e.g., type(load("1")) != type(load("1.1")) != type(load("1.1.1"))
.
I am seeing this schema validation error in the bot:
xref: https://github.com/regro/cf-scripts/actions/runs/8409784399/job/23027477235