conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
146 stars 170 forks source link

add default branches that are ignore by smithy for uploads #1904

Open beckermr opened 3 months ago

beckermr commented 3 months ago

Right now, one can set an appropriate key in the conda-forge.yml to have smithy only do uploads for certain branches. This is useful, but @jaimergp and I discussed a separate scheme that we think could be a nice default and enable some new things. The idea is to always disallow uploads from anything that matches the following globs/regex:

If we moved to this system, then we'd avoid common user errors of uploads happening when they do not fork the feedstock and we could use branches that start with _ for automated tasks like rerendering.

Thoughts @conda-forge/core?

h-vetinari commented 3 months ago

Why not do an allowlist instead of a blocklist? Something like main|dev|rc + ^v?[\d\.]+(\.x)?$; or maybe just main and enable extending that list through conda-forge.yml?

In any case, an allowlist seems way more waterproof than chasing holes in our blocklists to me.

beckermr commented 3 months ago

I don't care how it is phrased so happy with whatever in terms of allow vs reject lists.

One vote in favor of an expanded reject list is that if we instated allow lists we'd probably break existing feedstocks at some point.

The big point here, however, is that our current default of allowing everything is not as useful as several other possible default choices and I think we should change it.