BUG do not stomp on zipped keys after they are reordered properly

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.

https://conda-forge.org/

BSD 3-Clause "New" or "Revised" License

146 stars 170 forks source link

BUG do not stomp on zipped keys after they are reordered properly #1918

Closed beckermr closed 2 months ago

beckermr commented 2 months ago

Checklist

[ ] Added a news entry

closes #1917

h-vetinari commented 2 months ago

Tested this branch on the scipy-PR, and confirmed it works (see https://github.com/conda-forge/scipy-feedstock/pull/274/commits/7a3cbf2767f04e84fc8729f30686f2e9969f5934). Thanks a lot for the quick handling! :)

beckermr commented 2 months ago

Awesome! I tested it on my own simpler scipy branch as well. I am not happy with the fix and am waiting for someone with more conda-build expertise to comment on the appearance of top-level loop vars in the configs before moving on.

jakirkham commented 2 months ago

Would it be alright if we separate out the logging change into another PR?

Both changes seem reasonable, but combining them makes it a bit harder to parse what is happening here

beckermr commented 2 months ago

Yeah absolutely! Sorry for the mess of a diff. I am still struggling to understand some of thr subtle things in this PR and probably marked it as ready for review too early. :/

beckermr commented 2 months ago

closed by #1921