search

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
146 stars 169 forks source link

Add Go, Rust license bundling check #1951

Closed BastianZim closed 3 weeks ago

BastianZim commented 3 weeks ago

Checklist

This adds a linter that checks if go, rust licenses are bundled. More info is here: https://conda-forge.org/docs/maintainer/adding_pkgs/#licenses-of-included-dependencies

BastianZim commented 3 weeks ago

pre-commit.ci autofix

BastianZim commented 3 weeks ago

pre-commit.ci autofix

BastianZim commented 3 weeks ago

Tests are failing because of an unrelated test. I'll see what the issue is.

BastianZim commented 3 weeks ago

Seems like fitsio is not in https://raw.githubusercontent.com/regro/cf-graph-countyfair/master/mappings/pypi/name_mapping.yaml anymore(?) which is breaking the test.

@conda-forge/core Should I try and fix this?

beckermr commented 3 weeks ago

I'd just change the test to use another package on pypi. Maybe numpy?

BastianZim commented 3 weeks ago

Sure! But it is a valid package. Should I open an issue somewhere that it's not in the yaml?

BastianZim commented 3 weeks ago

I guess that fixed it. CC @beckermr

beckermr commented 3 weeks ago

Sure! But it is a valid package. Should I open an issue somewhere that it's not in the yaml?

No sorry. I switched the upstream url for that feedstock to github and that is why the bot no longer sees it as on pypi. This is expected. sorry for the trouble! I forgot about that test. Also, it'd be nice to separate the linter from this metadata generated by the bot, but that is another issue.

BastianZim commented 3 weeks ago

Ohhhh I see now that's a niche issue, interesting. 😄

Thank you!