search

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
146 stars 169 forks source link

chore: remove now obsolete setup.py #1955

Closed janl closed 1 week ago

janl commented 2 weeks ago

Checklist

There are two places where I’m not sure my changes are desired:

  1. https://github.com/neighbourhoodie/conda-smithy/commit/d11dce780edcfc3aee37040438abab3b4de5efa9 drops --single-version-externally-managed --record=record.txt from the install command because I did not manage to find any information about migrating those and I humbly request advice on whether this is correct or what the correct variant needs to be (tests pass locally).

  2. https://github.com/neighbourhoodie/conda-smithy/commit/57b07858148cd712fcdbf8ca26746a81c4759ae6 migrates away from setup.py but since this is about linting of other projects and not conda-smithy itself (afaict), I’m not sure, this is the right change to make and I’d need some advice from someone working on the project to make a final call.

I’m happy to adjust anything you might request.

Please let me know if I missed anything.

This is part of the STF work for Conda.

beckermr commented 2 weeks ago

This file was kept for folks who still used the setup.py directly. However, given that this feature is very much on its way out and has been deprecated for a while now, we can remove.

beckermr commented 2 weeks ago

See this line: https://github.com/conda-forge/conda-smithy/actions/runs/9596450561/job/26465117542?pr=1955#step:5:31

janl commented 1 week ago

Thank you for the quick review and my apologies for opening a clearly sub-par PR. I was a bit over-eager to close this out.

I have updated the PR text to reflect the additional work and open questions, thank you in advance for any hints.

Apologies also for missing the news item initially.