conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
146 stars 169 forks source link

HashableDict is removed in conda_build 24.7 #1967

Closed minrk closed 1 week ago

minrk commented 1 week ago

HashableDict is deprecated in conda-build 24.5.0 in favor of frozendict.deepfreeze, removed in 24.7.

ref: https://github.com/conda/conda-build/pull/5284

rerender's working for me with this change and conda-build 24.5.1.39_gc49182fe. Rerender time is reduced by about 90% for me with 24.7.x, so I'm looking forward to this release.

minrk commented 1 week ago

Turns out deepfreeze is super expensive (~10x) compared to HashableDict for our purposes. Measuring a rerender of petsc4py:

with deepfreeze:

Screenshot 2024-06-28 at 11 38 05

with HashableDict:

Screenshot 2024-06-28 at 11 37 33

so keeping HashableDict saves about 1 minute on a 5 minute rerender.

beckermr commented 1 week ago

Thank you!