[ ] Regenerated schema JSON if schema altered (python conda_smithy/schema.py)
Conda smithy makes an HTTP request without timeout. This can cause a hang/deadlock - in my case for longer than 1 minute. Nothing was happening, no CPU in htop, no logs.
When I hit ctrl+c the traceback showed the program got stuck in:
def get_most_recent_version(name, include_broken=False):
request = requests.get(
"https://api.anaconda.org/package/conda-forge/" + name
)
which lacks a timeout.
This PR adds a timeout of 60 seconds which should be reasonable and prevent deadlocks. As smithy runs in CI, it's probably a good idea to have it fail rather than stall indefinitely.
Mitigates #1973
Checklist
news
entrypython conda_smithy/schema.py
)Conda smithy makes an HTTP request without timeout. This can cause a hang/deadlock - in my case for longer than 1 minute. Nothing was happening, no CPU in htop, no logs.
When I hit
ctrl+c
the traceback showed the program got stuck in:which lacks a timeout.
This PR adds a timeout of 60 seconds which should be reasonable and prevent deadlocks. As smithy runs in CI, it's probably a good idea to have it fail rather than stall indefinitely.