fix: move back needed families

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.

https://conda-forge.org/

BSD 3-Clause "New" or "Revised" License

151 stars 176 forks source link

fix: move back needed families #1983

Closed nichmor closed 2 months ago

nichmor commented 2 months ago

Checklist

[ ] Added a news entry
[ ] Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

wolfv commented 2 months ago

This is to fix a potential breakage here: https://github.com/regro/cf-scripts/blob/c5c49476e9f4b292c1ec64c0cc53194a9e92efae/conda_forge_tick/migrators/license.py#L15

nichmor commented 2 months ago

Just to be clear, you are free to move the base definition of NEEDED_FAMILIES to the .utils module combined with importing it into .lint_recipe. That won't break the API. Removing it all together from .lint_recipe is the issue.

It is true but I think it's better to keep them in one place and just pass as some arguments