BUG: Correctly render team urls in README Feedstock Maintainers

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.

https://conda-forge.org/

BSD 3-Clause "New" or "Revised" License

147 stars 177 forks source link

BUG: Correctly render team urls in README Feedstock Maintainers #1990

Closed carterbox closed 1 month ago

carterbox commented 1 month ago

GitHub team pages have a different URL structure than regular users. Add a conditional to the template for README Feedstock Maintainers to check for "/" and use the team URL for maintainers which contain "/" because regular user names cannot contain "/".

Closes #1989

Checklist

[x] Added a news entry
[ ] Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

isuruf commented 1 month ago

Let's do this in https://github.com/conda-forge/conda-smithy/blob/0e2a3b6c99be0624fd842ca1482111f4c0d7d36f/conda_smithy/configure_feedstock.py#L2093 and set maintainer_urls which can be used in jinja.

carterbox commented 1 month ago

Moving the url generating logic to python is going to make this implementation more complicated because we will have to loop over the user names in two different places: once to generate the urls, once to render the README. And now the README template will have to zip the usernames and urls together.

beckermr commented 1 month ago

pre-commit.ci autofix