search

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
152 stars 183 forks source link

conda-smithy fails to create `.scripts/logging_utils.sh` #2108

Closed joaander closed 3 weeks ago

joaander commented 4 weeks ago

Solution to issue cannot be found in the documentation.

Issue

In a version bump for rowan (https://github.com/conda-forge/rowan-feedstock/pull/14), last updated several years ago, conda-smithy rerender updated .scripts/run_docker_build.sh but did not create .scripts/logging_utils.sh. Here is the failing CI: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1066373&view=logs&jobId=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc&j=7b6f2c87-f3a7-5133-8d84-7c03a75d9dfc&t=9eb77fd2-8ddd-5444-8fc0-71cb28dcb736

Debugging locally, the line that fails is ( endgroup "Configure Docker" ) 2> /dev/null. The error message that is masked by 2> /dev/null is: .scripts/run_docker_build.sh: line 79: endgroup: command not found

The root cause is that .scripts/logging-utils.sh is not present in the repository. conda-smithy should create this file when it does not exist. Note that .scripts/logging-utils.sh is ignored by .gitignore, which is possibly related to this issue:

$ git add logging_utils.sh
The following paths are ignored by one of your .gitignore files:
.scripts/logging_utils.sh
hint: Use -f if you really want to add them.
hint: Turn this message off by running
hint: "git config advice.addIgnoredFile false"

I have force-added logging_utils.sh to rowan-feedstock to proceed with the release. However, conda-smithy should be modified to more robustly include the file so that other feestocks can be successfully updated.

Installed packages

This error occurs on the CI build platform before conda is installed.

Environment info

This error occurs on the CI build platform before conda is installed.

jakirkham commented 3 weeks ago

Thanks Joshua! šŸ™

FWIW was also wondering if this was .gitignore related

Tried re-rendering locally myself to get more info, but it appears to have added the file šŸ˜• Here are my results: https://github.com/conda-forge/rowan-feedstock/pull/15

Could you please share a bit more info like...?

  1. conda info
  2. conda-smithy --version
  3. conda list

Perhaps there is another relevant detail we are missing

beckermr commented 3 weeks ago

This was a bug in the webservices rerendering. Try it again to confirm it is fixed.

xref: https://github.com/conda-forge/conda-forge-webservices/pull/749 https://github.com/conda-forge/conda-forge-feedstock-ops/pull/28

joaander commented 3 weeks ago

Thanks for the fix! I confirmed that a webservices rerender this morning adds logging_utils.sh:

https://github.com/conda-forge/rowan-feedstock/pull/16 https://github.com/conda-forge/rowan-feedstock/pull/16/commits/aca7d2a602f367524f166a31b8e3ea56b9397327#diff-6b25692a12705c6bc05b24dcc34894194146d8819d3c604700fac830224072cf