handle source.url as list in pypi.org linter rule

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.

https://conda-forge.org/

BSD 3-Clause "New" or "Revised" License

152 stars 183 forks source link

handle source.url as list in pypi.org linter rule #2111

Closed bollwyvl closed 3 weeks ago

bollwyvl commented 3 weeks ago

The new linter rule (while great) doesn't take into account that a source.url can be a list of URLs (with fallback).

This is an issue for e.g. selenium, where the upstream git tag (bleargh) can be one of either:

4.26.0
python-4.26.1

Checklist

[x] Added a news entry
[x] Regenerated schema JSON if schema altered (python conda_smithy/schema.py)

bollwyvl commented 3 weeks ago

@conda-forge/conda-smithy ready for review

bollwyvl commented 3 weeks ago

Thanks!

beckermr commented 3 weeks ago

Thank you! I just released smithy with the fix.

ocefpaf commented 3 weeks ago

BTW, that change should probably be included in a piggy back migration and/or a rerender to make it easier to spread the change across all feedstocks. I've been away from smithy and the bot's code for a while but I can give it a go next week if no one beats me to it.