conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
152 stars 183 forks source link

Set rattler cache to /tmp when building linux from osx #2124

Closed hadim closed 1 week ago

hadim commented 2 weeks ago

Checklist

hadim commented 2 weeks ago

Similar to https://github.com/conda-forge/staged-recipes/pull/28119

hadim commented 2 weeks ago

LGTM

hadim commented 2 weeks ago

This should go in build_steps.sh.tmpl, I think. There's a rattler-specific env var we are already using in other platforms, which would be preferred instead of the system-wide XDG setting.

I can move the logic to build_steps.sh.tmpl but I don't see any rattler env var I can re-use there. I am also not aware of another env var to set the rattler cache than XDG_CACHE_HOME.

Also, the current logic is specific to building linux from macOS with docker. Should I keep that same logic if moving to build_steps.sh.tmpl?

jaimergp commented 2 weeks ago

I am also not aware of another env var to set the rattler cache than XDG_CACHE_HOME.

See https://pixi.sh/v0.21.1/features/environment/#caching. I think RATTLER_CACHE_DIR applies here.

Also, the current logic is specific to building linux from macOS with docker.

Ah, ok, in that case build-locally is ok. Sorry!

hadim commented 2 weeks ago

I just tested locally and it does not work. It seems like RATTLER_CACHE_DIR only works with pixi.

hadim commented 2 weeks ago

I opened a ticket at https://github.com/prefix-dev/rattler-build/issues/1171

hadim commented 2 weeks ago

LGTM once a new rattler-build version is out. See https://github.com/prefix-dev/rattler-build/issues/1171#issuecomment-2468139785 for details

jaimergp commented 1 week ago

Thanks! Ping me again once the new rattler-build is out!

jaimergp commented 1 week ago

Looks like 0.31 is out. Is that what we need for the new env var? Reopening just in case.

hadim commented 1 week ago

Let's wait for 0.31 to make it in https://github.com/conda-forge/rattler-build-feedstock

hadim commented 1 week ago

Actually for conda-smithy, you can merge @jaimergp !