search

conda-forge / conda-smithy

The tool for managing conda-forge feedstocks.
https://conda-forge.org/
BSD 3-Clause "New" or "Revised" License
152 stars 183 forks source link

allow equal-signs in CFEP-25 pins #2167

Open h-vetinari opened 2 days ago

h-vetinari commented 2 days ago

The original version of CFEP-25 used:

test:
  requires:
    - python ={{ python_min }}

This is a natural an allowed syntax in conda, as is 

test:
  requires:
    - python =={{ python_min }}

We shouldn't spuriously lint on those, hence allow equal signs in the pattern.

beckermr commented 1 day ago

Still breaking: https://github.com/conda-forge/conda-forge-webservices/actions/runs/12016308858/job/33496223500

beckermr commented 12 hours ago

This PR https://github.com/conda/conda-build/pull/5555 fixes the issue (and I tested it live on a feedstock). We'll need to wait until 25.1.0 to see the fix live.

h-vetinari commented 4 hours ago

This PR conda/conda-build#5555 fixes the issue (and I tested it live on a feedstock). We'll need to wait until 25.1.0 to see the fix live.

Cool, thanks a lot! (and nice PR number! 😁)