Closed erykoff closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Thanks @erykoff !! :pray:
For me, I'm good with almost anything which gets this up on conda in the easiest and maintainable way possible.
Strong preference for anything which uses existing wheels, without any dependencies, already on PyPi. These include Python 3.10 for basically every distribution and think it was one of the first to have PyPy 3.8 support. :wink:
That said, I'm ironically not the best person to review this PR.
Unfortunately, there are very few of us that are qualified to have an opinion with this stuff! It looks like the build is not succeeding on linux_aarch and ppc.
So the bad news is that I have no idea how to get the aarch64 and ppc64le jobs working; in the meantime I'm going to revert back to native...
The worse news is that my changes to meta.yaml
didn't appear to fix the osx-arm64 cross builds. At least my local test didn't work, which was a bit convoluted because I'm using an emulated x86 env on my M1 mac and then trying to do a cross-build to arm64.
I think that using existing wheels as-is is considered a "last resort" on conda-forge, but I also have no idea how to get maturin to do cross compiling...
And I'm also wondering where the osx-arm64 py310 wheels are on pypi.
Apparently the pinned version of libmimalloc-sys 0.1.23 doesn't support aarch64 or ppc64le; if this was updated upstream in the Cargo files then I think that would make those builds work.
@conda-forge-admin, rerender
Okay, the rust compiler misconfigure that @isuruf noticed is the reason that the arm64 cross compile wasn't working. Locally I was able to successfully cross compile. So this PR should fix #17 at least.
Oh dear lord, the cross-builds with python 3.10 think that the python version is 3.1 and then failing. Any idea where this check is happening and failing?
From conda people: "3.10 needs to be a string in the yaml file"
it's actually a bug in conda-build
. Working on it...
Okay, this really is good to go.
To summarize: the version has been updated to 2.5.0, which properly supports cross compilation and python3.10; the python3.10 builds have been added to the matrix; and the proper PYO3_CROSS
env vars have been set and the correct rust compiler is selected so that cross compilation works correctly, fixing #17 .
I am definitely going to be looking out for erroneous string comparisons in github actions from here on out ...
Anyway, feel free to merge whenever. This will then allow fastparquet to be migrated to py310 (as well as fixing the osx-arm64 conda forge installation!).
This will then allow fastparquet to be migrated to py310
Only with my self-made thrift :). https://github.com/dask/fastparquet/pull/633
Ha! Well, this is necessary if not sufficient ...
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)